Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading First Time #45

Merged
merged 2 commits into from
Oct 3, 2020
Merged

Conversation

khushali6
Copy link
Contributor

@khushali6 khushali6 commented Oct 1, 2020

Pull Request Template

Description

Please include a summary of the problem and about the approach to solve the solution. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Put check marks:

Have you made changes in README file ?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@khushali6 khushali6 changed the title Add files via upload Uploading First Time Oct 1, 2020
@GouravRusiya30
Copy link
Member

GouravRusiya30 commented Oct 1, 2020

@khushali6 Thanks for creating first PR for this repo. But please add details on README file also like this ---> #3

@GouravRusiya30
Copy link
Member

GouravRusiya30 commented Oct 2, 2020

@khushali6 Please update the readme file for the time and space complexity details.

@GouravRusiya30 GouravRusiya30 merged commit 72228e1 into codedecks-in:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants