Mysql db name pr 1.x (#264)

* Adding escaped backticks to db names to be safe.

* Looks like Ansible auto-escapes backticks.

* Adding backticks to database names for creating MySQL users too.

* Adding extra mysqldump flags to stop restores failing on RDS.

* Removing ignore_errors.

* Updating mysqldump query.

Author: gregharvey

roles/_init/defaults/main.yml

@@ -3,7 +3,8 @@
 # this will ensure defaults to other roles too.
 # If you are using ce-provision to deploy infrastructure this must match the `user_deploy.username` variable
 deploy_user: "deploy"
-_mysqldump_params: "--set-gtid-purged=OFF --skip-definer --max-allowed-packet=128M --single-transaction --skip-opt -e --quick --skip-disable-keys --skip-add-locks -C -a --add-drop-table"
+# for MySQL CE you might want to add '--set-gtid-purged=OFF --skip-definer' here
+_mysqldump_params: "--max-allowed-packet=128M --single-transaction --skip-opt -e --quick --skip-disable-keys --skip-add-locks -C -a --add-drop-table"
 drupal:
   sites:
     - folder: "default"

roles/deploy_code/tasks/cleanup.yml

@@ -128,7 +128,7 @@
 - name: Check if we have a mount already.
   ansible.builtin.shell:
     cmd: "mount | grep {{ deploy_base_path }}"
-  ignore_errors: true
+  failed_when: false
   register: _deploy_code_mount_check
   when:
     - deploy_code.mount_sync is defined

roles/lhci_run/tasks/main.yml

@@ -2,12 +2,12 @@
 - name: Check if 'lhci' is available.
   ansible.builtin.command: "which lhci"
   register: _lhci_run_check_result
-  ignore_errors: true
+  failed_when: false
 
 - name: Check if 'Xvfb' is running.
   ansible.builtin.shell: "pgrep Xvfb"
   register: _lhci_run_check_xvfb_result
-  ignore_errors: true
+  failed_when: false
   when:
     - _lhci_run_check_result.rc == 0