This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
added profile setting APIs refs #192 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,21 @@ def show | |||
| render_error 'user not found', 403 | |||
| end | |||
|
|
|||
| def update | |||
| def add(map, key) | |||
There was a problem hiding this comment.
This doesn't define inner method.
It is better to use add = lambda{|map,key| ...} or private method.
|
LGTM 🍵 |
|
LGTM 🍣 |
shimomura1004
added a commit
that referenced
this pull request
Jun 25, 2014
added profile setting APIs refs #192
|
Thank you for your reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.