Multiple forms with captcha

[formatz]

Hi,

If you add multiple forms to a page and each of them contains a captcha field, only the last field is saved to session data (it overrides the actual value).

I fixed this by adding the formId value to the name of the captcha field :

    public function addCaptcha($arrData=array())
    {
        if (!isset($this->arrFields['captcha']))
        {
            $this->arrFields['captcha'] = array_merge_recursive(array
            (
                'name'      => 'captcha_'.$this->strFormId,
                'label'     => $GLOBALS['TL_LANG']['MSC']['securityQuestion'],
                'inputType' => 'captcha',
                'eval'      => array('mandatory'=>true)
            ), $arrData);
        }
    }

Thanks,
Fabien

[qzminski]

Thanks for reporting this issue and fixing it!

[Toflar]

Not sure this is correct, Kamil. If what @formatz said is true, it's true for every form field, not only for the captcha field! So what your solution does is this:

// now works
$_SESSION['FORM_DATA']['captcha_myFormId'] = 'foobar';  // captcha form 1
$_SESSION['FORM_DATA']['captcha_myOtherFormId'] = 'barfoo'; // captcha form 2

// still doesn't work
$_SESSION['FORM_DATA']['myFormField'] = 'foobar'; // my form field of form 1
$_SESSION['FORM_DATA']['myFormField'] = 'foobar'; // my form field of form 2

Correct would be this

$_SESSION['FORM_DATA']['myFormId']['captcha'] = 'foobar';  // captcha form 1
$_SESSION['FORM_DATA']['myOtherFormId']['captcha'] = 'barfoo'; // captcha form 2
$_SESSION['FORM_DATA']['myFormId']['myFormField'] = 'foobar'; // my form field of form 1
$_SESSION['FORM_DATA']['myOtherFormId']['myFormField'] = 'foobar'; // my form field of form 2

[qzminski]

I think the problem was with multiple captchas, as they were not validated correctly? @formatz, can you precise what was the problem?

[formatz]

Yes @qzminski , the problem was the validation.
Only the last Captcha key and data were saved in Session (they all overwrites the same key in session array).

[Toflar]

Only the last Captcha key and data were saved in Session (they all overwrites the same key in session array).

But that's what I was saying. That's the case for all form fields that have the same name. So if you have two forms with the form field name vehicle, the second one is going to overwrite the first one :-)

[formatz]

Perhaps I don't understand your problem.
For me it doesn't matter that each forms contain the same input names because only the values from the submitted form are sent (each form id is unique and I can check the "FORM_SUBMIT" value).
(I compute the DCA values from a specific table. I didn't use the form generator)