Add retries to download functions #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To mitigate occasional connection errors #58
|
Adding a retry loop is definitely a good idea! I think this can be done without an extra dependency, though… I’m pretty sure requests has something for retrying built in. Is that something you’d be happy to look at using, @tillywoodfield? Happy for a PR, but I’d rather avoid the extra dependency if possible. |
|
Hi @andylolz, no problem that makes sense, I'm happy to rework it |
andylolz
approved these changes
Mar 6, 2024
|
Version 3.4.0 is now on pypi, and includes this feature: https://pypi.org/project/iatikit/3.4.0/ |
|
Thanks @andylolz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retries to top-level functions in
utils.downloadto mitigate occasional connection errors.#58
Also relates to codeforIATI/iati-tables#37