Merge branch 'reset-latest-snapshot' into 'master'

fix: choose the last snapshot when reset to the latest snapshot is requested

See merge request postgres-ai/database-lab!708

Author: agneum

engine/internal/provision/mode_local.go

@@ -13,6 +13,7 @@ import (
 	"os"
 	"os/exec"
 	"regexp"
+	"sort"
 	"strconv"
 	"sync"
 	"sync/atomic"
@@ -409,6 +410,22 @@ func (p *Provisioner) getSnapshot(snapshotID string) (*resources.Snapshot, error
 		return nil, errors.Errorf("snapshot %q not found", snapshotID)
 	}
 
+	return getLatestSnapshot(snapshots)
+}
+
+func getLatestSnapshot(snapshots []resources.Snapshot) (*resources.Snapshot, error) {
+	if len(snapshots) == 0 {
+		return nil, errors.New("no snapshots available")
+	}
+
+	sort.Slice(snapshots, func(i, j int) bool {
+		if !snapshots[i].DataStateAt.IsZero() && !snapshots[j].DataStateAt.IsZero() {
+			return snapshots[i].DataStateAt.After(snapshots[j].DataStateAt)
+		}
+
+		return snapshots[i].CreatedAt.After(snapshots[j].CreatedAt)
+	})
+
 	return &snapshots[0], nil
 }
 

engine/internal/provision/mode_local_test.go

@@ -190,3 +190,53 @@ func TestParsingDockerImage(t *testing.T) {
 		}
 	})
 }
+
+func TestLatestSnapshot(t *testing.T) {
+	t.Run("Test selecting the latest snapshot ID", func(t *testing.T) {
+		dateTime := time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC)
+
+		testCases := []struct {
+			snapshots  []resources.Snapshot
+			expectedID string
+			err        error
+		}{
+			{
+				err: errors.New("no snapshots available"),
+			},
+			{
+				snapshots: []resources.Snapshot{
+					{ID: "test1", CreatedAt: dateTime},
+					{ID: "test2", CreatedAt: dateTime.Add(time.Hour)},
+					{ID: "test3", CreatedAt: dateTime.Add(-time.Hour)},
+				},
+				expectedID: "test2",
+			},
+			{
+				snapshots: []resources.Snapshot{
+					{ID: "test1", DataStateAt: dateTime},
+					{ID: "test2", DataStateAt: dateTime.Add(time.Hour)},
+					{ID: "test3", DataStateAt: dateTime.Add(2 * time.Hour)},
+				},
+				expectedID: "test3",
+			},
+			{
+				snapshots: []resources.Snapshot{
+					{ID: "test1", CreatedAt: dateTime, DataStateAt: dateTime},
+					{ID: "test2", CreatedAt: dateTime.Add(time.Hour), DataStateAt: dateTime.Add(time.Hour)},
+					{ID: "test3", CreatedAt: dateTime.Add(-time.Hour), DataStateAt: dateTime.Add(2 * time.Hour)},
+				},
+				expectedID: "test3",
+			},
+		}
+
+		for _, tc := range testCases {
+			latest, err := getLatestSnapshot(tc.snapshots)
+			if err != nil {
+				assert.EqualError(t, err, tc.err.Error())
+				continue
+			}
+
+			assert.Equal(t, tc.expectedID, latest.ID)
+		}
+	})
+}