Most popular pages #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add error handling to parseResponse if d3.json failes, or if there are no results in the API reponse
chai-change is a plugin for chai to test changes made by functions
show todays top pages and not the realtime top pages from the last 30 minutes
we want to show how many users are mobile or desktop users so we add the deviceCategory to the dimensions and change the column for the actual visitor count
use a parseData method to actually parse the data
update the pages where the url exists for the next result from GA and update the visits accordingly for now fesktop views come first from GA so mobile gets updated. needs a few adjustments: - reorder for overall count not only desktop count - evaluate the max-results param for the API call (1000 might be too much) - tablet needs to be incorperated into mobile on the aggregation
always show the most popular page on top GA sorts the pageviews by deviceCategory since we want that dimension too that's why we need to adjust the ordering by summing the two dimensions and sort on the sum
add helper to get the deviceCategory if the deviceCategory is tablet return the category mobile we want to incorporate the tablet data into the mobile category
Conflicts: karma.conf.js public/index.html
add icons for each device type and add the same bar as active pages and search to repeat the color
|
Updated the style: |
Conflicts: public/index.html public/stylesheets/base.css
remove use of mustache and use the template hleper with handlebars
format numbers to include thousand seperator
toLocaleString does not work consistently use different implementation
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the most popular pages panel.
Instead of showing the "Realtime" most popular pages from the last 30 minutes (realtime) it now shows the most popular pages of the day.
It also adds support to show the device type the users are accessing the most popular pages with.
Related Issues
#43
Screenshot
To Do before merging