CCAP-63 Add new PDF custom preparers #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
reviewed
Jul 24, 2024
analoo
reviewed
Jul 24, 2024
| submittedAt.ifPresent(offsetDateTime -> { | ||
| offsetDateTime.atZoneSameInstant(chicagoTimeZone); | ||
| String formattedSubmittedAtDate = offsetDateTime.atZoneSameInstant(chicagoTimeZone).format(receivedTimestampFormat); | ||
| results.put("receivedTimestamp", new SingleField("receivedTimestamp", formattedSubmittedAtDate, null)); |
There was a problem hiding this comment.
Wondering if we can use formattedSubmittedAtDate and formattedSubmittedAtDate to set the value instead of adding new logic.
It seems like the receivedTimestamp value we want is =
submission.getInputData().get("formattedSubmittedAtDate") +", "+submission.getInputData().get("formattedSubmittedAtTime")+ " CST"
There was a problem hiding this comment.
Hmmm formattedSubmittedAtDate isn't available. Maybe it related to this bug mentioned in slack. Looking into it.
There was a problem hiding this comment.
Ok so I'm not going to use formattedSubmittedAtDate and formattedSubmittedAtTime for a few reasons:
- These values are not added until the action
FormatSubmittedAtDateruns. Which means this couldn't be unit tested. - The format that those produce are in a different format.
- 🔴
07/25/2024 at 3:22 PM - 🟢
June 25, 2024, 3:22 PM CDT
CSTcan't be a string because half the year it'sCSTand the other half of the year it'sCDT.- The action is really just meant to be a utility to format the date for display on the screen and I don't want to also add other responsibilities to it.
analoo
approved these changes
Jul 24, 2024
cy-by
changed the title
cy-by
force-pushed
the
CCAP-63-map-time-stamp-and-applicant-name
branch
from
f76188e
to
574748d
Compare
|
Looks great! |
cram-cfa
approved these changes
Jul 26, 2024
added 2 commits
July 26, 2024 10:36
- Add unit test for parentFullName - Add unit test for receivedTimestamp - Ignore these fields in verifyPDF
… on the screen it needs the variables for rendering
cy-by
force-pushed
the
CCAP-63-map-time-stamp-and-applicant-name
branch
from
574748d
to
c15f9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
CCAP-63
✍️ Description
parentFullNamereceivedTimestampverifyPDFbecause fields from custom preparers aren't in the db and that's a limitation of our pdf testing.FormatSubmittedAtDateto happen on thesubmit-confirmationscreen so that it was triggering after thesubmittedAtis filled, so that the confirmation screen correctly displays the formatted date time (this was not apart of the ticket but it was simple and closely releated).✅ Completion tasks