Add empty string check for day to match how the app is submitting dat… #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
commented
Jul 26, 2024
| @@ -118,7 +118,7 @@ public static String getDateInputWithDayOptional(Submission submission, String i | |||
| return ""; | |||
| } else if (year == null || month == null) { | |||
| throw new IllegalArgumentException("Date must be complete if specified"); | |||
| } else if ( day == null ){ | |||
| } else if ( day == null || day.isEmpty() ){ | |||
There was a problem hiding this comment.
the form will actually submit day as an empty string but adding a null check here as well to be extra careful.
year and month should never be saved as null because there is a front end validation keeping the user from being able to save when those two values are blank if either of them is present.
cy-by
approved these changes
Jul 26, 2024
cram-cfa
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a in the form
🔗 Jira ticket
✍️ Description
📷 Design reference
✅ Completion tasks