Avoiding multiple DB calls for status update

[#180196891]
codeforamerica · Dec 2, 2021 · 81a956a · 81a956a
1 parent d09dab7
commit 81a956a
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/src/main/java/org/codeforamerica/shiba/pages/PageController.java b/src/main/java/org/codeforamerica/shiba/pages/PageController.java
@@ -525,7 +525,9 @@ ModelAndView postFormPage(
 
       Application application = applicationFactory.newApplication(applicationData);
       applicationRepository.save(application);
-      applicationRepository.updateStatusToInProgress(application, routingDecisionService);
+      if (applicationConfiguration.getLandmarkPages().isStartTimerPage(pageName)) {
+        applicationRepository.updateStatusToInProgress(application, routingDecisionService);
+      }
       return new ModelAndView(String.format("redirect:/pages/%s/navigation", pageName));
     } else {
       return new ModelAndView("redirect:/pages/" + pageName);

diff --git a/src/test/java/org/codeforamerica/shiba/pages/PageControllerTest.java b/src/test/java/org/codeforamerica/shiba/pages/PageControllerTest.java
@@ -253,7 +253,7 @@ void shouldSaveApplicationOnEveryFormSubmission() throws Exception {
     when(applicationRepository.getNextId()).thenReturn(applicationId);
     when(applicationFactory.newApplication(applicationData)).thenReturn(application);
 
-    mockMvc.perform(post("/pages/secondPage")
+    mockMvc.perform(post("/pages/firstPage")
         .param("foo[]", "some value")
         .contentType(MediaType.APPLICATION_FORM_URLENCODED_VALUE));
 
@@ -262,8 +262,32 @@ void shouldSaveApplicationOnEveryFormSubmission() throws Exception {
         .contentType(MediaType.APPLICATION_FORM_URLENCODED_VALUE));
 
     verify(applicationRepository, times(2)).save(application);
-    verify(applicationRepository, times(2)).updateStatusToInProgress(application,
-        routingDecisionService);
+    assertThat(applicationData.getId()).isEqualTo(applicationId);
+  }
+
+  @Test
+  void shouldSaveApplicationStatusOnStartTimerPage() throws Exception {
+    applicationData.setStartTimeOnce(Instant.now());
+
+    String applicationId = "someId";
+    applicationData.setId(applicationId);
+    Application application = Application.builder()
+        .id(applicationId)
+        .applicationData(applicationData)
+        .build();
+    when(applicationRepository.getNextId()).thenReturn(applicationId);
+    when(applicationFactory.newApplication(applicationData)).thenReturn(application);
+
+    mockMvc.perform(post("/pages/firstPage")
+        .param("foo[]", "some value")
+        .contentType(MediaType.APPLICATION_FORM_URLENCODED_VALUE));
+
+    mockMvc.perform(post("/pages/secondPage")
+        .param("foo[]", "some other value")
+        .contentType(MediaType.APPLICATION_FORM_URLENCODED_VALUE));
+
+    verify(applicationRepository, times(1))
+        .updateStatusToInProgress(application, routingDecisionService);
     assertThat(applicationData.getId()).isEqualTo(applicationId);
   }