Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail test if conversation is empty #19

Conversation

Naktibalda
Copy link
Contributor

If conversation is empty it isn't testing anything, so it should fail.

This change should help to understand issue caused by using \n on Windows easier.
It is very confusing for new users like me.

@codeforequity-at
Copy link
Owner

Hi, this is basically a very fine addition.
Would you mind to rewrite your code to use the "readConvoReject(err)"-Callback instead of throwing an exception - just to follow the general coding style.

Copy link
Owner

@codeforequity-at codeforequity-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to rewrite your code to use the "readConvoReject(err)"-Callback instead of throwing an exception - just to follow the general coding style.

@Naktibalda
Copy link
Contributor Author

That exception is caught 3 lines down.

@codeforequity-at
Copy link
Owner

Solved with latest commit! Thanks for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants