-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when referencing undefined parameters variable #1760
Conversation
2 commits as I updated the contributions.md seperately. |
Hi @krethan ! Thank you for your contribution to this project - really appreciated! One question: How can I reproduce the error, that your change is fixing? I haven't seen this before... |
@chrjorgensen I believe this shows up in the debug console (during debug) or the developer consider (during runtime). I have seen this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krethan I left one small request - otherwise, working as expected. Thanks!
Changing let to const as suggested.
@worksofliam Changed the let to const and moved it into the if block. This issue is occuring when setting up the connection for the first time after the extension is installed. After a connection is successful this is not an issue anymore. |
Just retested and works as expected. This error had been lingering for a while, so it's nice to see it fixed. Thanks for your PR! |
When parameters variable is undefined it is generating an error when trying to reference parameters.name. Added check to ensure parameters.name is defined before updating the connection information. There is also no need to update the connection information if parameters.name is undefined.