Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take in account for possible ASP in compile path #1771

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Take in account for possible ASP in compile path #1771

merged 2 commits into from
Jan 10, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

There was an issue where the deploy path could be inside of an ASP without it being on the path explicitly.

For example, if the deploy path was: /home/user/abc, the compiler can possibly return /MYASP/home/user/abc in the evfevent logs.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam added bug A confirmed issue when something isn't working as intended build Build will be available inside PR. labels Jan 9, 2024
@worksofliam worksofliam requested a review from a team January 9, 2024 18:35
@worksofliam worksofliam linked an issue Jan 9, 2024 that may be closed by this pull request
Problem tab issue #1678
Closed
@worksofliam worksofliam mentioned this pull request Jan 9, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

👋 A new build is available for this PR based on e6e8fa2.

@worksofliam
Copy link
Contributor Author

@chrjorgensen @sebjulliand looks like the user is happy with the fix: #1678 (comment)

Any chance a code review could happen before merge? Thanks!

sebjulliand
sebjulliand approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@worksofliam worksofliam merged commit 3e1bb17 into master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended build Build will be available inside PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem tab issue
2 participants
@worksofliam @sebjulliand