Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build functionality for cross pod interactions #38

Closed
leekahung opened this issue Mar 1, 2023 · 6 comments · Fixed by #40
Closed

Build functionality for cross pod interactions #38

leekahung opened this issue Mar 1, 2023 · 6 comments · Fixed by #40
Assignees
Labels
enhancement Enhancement of existing features

Comments

@leekahung
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Still need to implement cross pod querying/writing

Describe the solution you'd like
Porting the existing vanilla versions in the project and refactoring them for React.

Describe alternatives you've considered
None at this moment.

Additional context
None at this moment.

@leekahung leekahung added the enhancement Enhancement of existing features label Mar 1, 2023
@leekahung leekahung self-assigned this Mar 1, 2023
@leekahung leekahung linked a pull request Mar 2, 2023 that will close this issue
@leekahung
Copy link
Contributor Author

leekahung commented Mar 2, 2023

Have explored how much the new linting settings on #37 would affect code. Managed to narrow the number of problems to 26 locally after modification of code base with base settings, but 15 of these are still lint errors. Will be discussed with Greg and Jared when discussing rules for linting. Reverted previous commit to issue #40 that explores linting.

@leekahung
Copy link
Contributor Author

Progress has been made in #40 with regards to cross pod interactions. In recent commits, we've managed to:

  1. Create function to generate ACL file upon file upload and set ACL perms to user's pod automatically
  2. Developed an interface to set ACL perms (either give or revoke) to other users for document type (only read access is provided at this time)
  3. Developed an interface to query/search for that document type after permission is given

Functionality to cross pod write is still being built and explored at the moment.

@leekahung
Copy link
Contributor Author

Might leave cross pod write out at the moment until we know where to store these files from other Pods and simply merge existing functionalities to Development.

@GoodGuyGregory
Copy link
Contributor

I think it would be easier to merge the Linting changes you have from the code I started

@GoodGuyGregory
Copy link
Contributor

I'm fine with whatever preferences we have they can always be changed/modified

@leekahung
Copy link
Contributor Author

#38 is now completed with #40 merged into Development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants