Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inactivity notification popup that toggles after 3 minutes of no … #101

Merged
merged 6 commits into from
Apr 29, 2023
Merged

Add inactivity notification popup that toggles after 3 minutes of no … #101

merged 6 commits into from
Apr 29, 2023

Conversation

benzelcurry
Copy link
Contributor

Issue-88: Inactivity message

Implementations/Features

  • Created an inactivity message component in the form of a modal that triggers after 3 minutes.
  • Only displays if a user is actively signed in
  • Displays in the center of user's screen.
  • Allows user to either close the modal and continue session or to log out.
  • Uses Material UI for base and components.
  • Just has inline styling for now, but could probably be spruced up in the future by the design team.

Notes

  • Can provide a picture of what the notification looks like. Not sure how to add it to the PR without uploading it to the repo as a whole.

leekahung
leekahung requested changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few things I want to touch on for revision.

src/components/Notification/InactivityMessage.jsx Outdated Show resolved Hide resolved
src/components/Notification/InactivityMessage.jsx Outdated Show resolved Hide resolved
src/components/Notification/InactivityMessage.jsx Outdated Show resolved Hide resolved
src/components/Notification/InactivityMessage.jsx Show resolved Hide resolved
@leekahung leekahung added enhancement Enhancement of existing features good first issue Good for newcomers labels Apr 29, 2023
@leekahung leekahung changed the base branch from Master to Development April 29, 2023 01:16
@leekahung
Copy link
Contributor

Also changing the merge to Development instead of Master

leekahung
leekahung approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@leekahung leekahung merged commit f966222 into codeforpdx:Development Apr 29, 2023
@leekahung leekahung mentioned this pull request Apr 29, 2023
Closed
@leekahung leekahung mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekahung leekahung leekahung approved these changes

Assignees

@benzelcurry benzelcurry

Labels
enhancement Enhancement of existing features good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benzelcurry @leekahung