Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Adjust "Our Partners" list to display as shown #40

Closed
katrinasperry opened this issue Nov 17, 2021 · 3 comments · Fixed by #70
Closed

Adjust "Our Partners" list to display as shown #40

katrinasperry opened this issue Nov 17, 2021 · 3 comments · Fixed by #70
Assignees
Milestone

Comments

@katrinasperry
Copy link
Contributor

katrinasperry commented Nov 17, 2021

Create PR that merges to partner_list-redesign branch

image

NOTE: all partner logos are already on the current site - keep them as is!

The partners html file can be found in: sections/partners.html
The _partners directory has all the md files <- probably don't need to modify that unless we're adding/removing partners.

@katrinasperry katrinasperry added this to the Partner list milestone Nov 17, 2021
@curtisbarnard curtisbarnard self-assigned this Mar 29, 2022
@curtisbarnard
Copy link
Contributor

Once I get the sponsor list updates approved and merged I'll update these cards. @katrinasperry a few design questions:

  1. Do you want the aspect ratio of the cards the same from mobile up to desktop?
  2. Do you want to maintain the current aspect ratio or use the updated aspect ratio from Figma:
    • Current Aspect ratio 2.14:
      • image
    • Updated aspect ratio 2.31:
      • image
  3. Confirm that I am removing the box shadow?

Thanks!

@katrinasperry
Copy link
Contributor Author

I really don't have strong feelings about aspect ratios 😂 so if you have other ideas, please share! Here's my best guess:

  1. Yes, let's keep the same aspect ratio across desktop and mobile views.
  2. Let's maintain the current aspect ratio.
  3. Yes to removing the box shadow!

Thanks so much!

@curtisbarnard curtisbarnard mentioned this issue Apr 4, 2022
4 tasks
@curtisbarnard
Copy link
Contributor

This is being taken care of on #70 , currently having some issues with getting the desktop layout to align correctly. See PR for more info.

container

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants