Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problème d'accessibilité sur les modals de la nouvelle version 0.6x.x #145

Closed
youssefElMkhantar opened this issue Jul 3, 2023 · 5 comments

Comments

@youssefElMkhantar
Copy link

Bonjour,

j'ai rencontré un problème d'accessibilité au niveau de la nouvelle version du modal. en fait meme si je définis un boutton et un onClick pour ouvrir manuellemnt le modal. la fonction creatModal() semble créer un boutton invisible sans lui donner de text. ce qui est confirmé par les essais que j'ai fait. voici quelques photos du problème.

Merci

erreur_accessibilite

button_accessibilite

handle_accessibilite

@garronej
Copy link
Collaborator

garronej commented Jul 3, 2023

Bonjour @youssefElMkhantar,
Merci pour avoir fait remontrer, je vois le problème. Je vais tacher de corriger.

@youssefElMkhantar
Copy link
Author

Bonjour @youssefElMkhantar,
Merci pour avoir fait remontrer, je vois le problème. Je vais tacher de corriger.

Merci

garronej added a commit that referenced this issue Jul 3, 2023
@garronej
Copy link
Collaborator

garronej commented Jul 3, 2023

Hello @youssefElMkhantar,

In response to the recent challenge concerning the invisible button in DSFR, it appears there is no straightforward method to remove it without compromising the server-ready status of the Modal component.

To counteract this limitation, I have implemented the following attributes on the respective buttons:

    tab-index="-1",
    aria-hidden="true"

These modifications are intended to enhance our accessibility compliance. However, should your accessibility tools continue to flag any issues, kindly let me know so I can address them promptly.

If necessary, I am prepared to collaborate with the @gouvfr/dsfr team to explore further solutions, ensuring we meet all accessibility requirements.

Thank you for your understanding, and I look forward to your feedback.

Best regards

@youssefElMkhantar
Copy link
Author

Hello @garronej
thanks, problem solved after updating to the latest version.

@garronej
Copy link
Collaborator

garronej commented Jul 4, 2023

cool, thaks for the feedback!

@garronej garronej closed this as completed Jul 4, 2023
sbourdon13 pushed a commit to sbourdon13/react-dsfr that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants