Add title for footer links that open in a new tab #153
Comments
|
Hi @slafayIGN, |
|
Thanks. The link to the etalab licence has the same issue in this component as well. |
|
I work with Sylvain and I'm working on this issue |
|
Sorry I forgot to address this. Thank you for working on this. Your change LGTM, don't forget to open a PR! |
21 tasks
sbourdon13
pushed a commit
to sbourdon13/react-dsfr
that referenced
this issue
Aug 11, 2023
garronej
added a commit
that referenced
this issue
Aug 13, 2023
fix: Add title for footer links that open in a new tab #153
|
Merged and available for versions >= v0.75.0 🚀 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue has been raised by an accessibility audit on an app using react-dsfr.
The 4 hardcoded links in the footer to "legifrance.gouv.fr", "gouvernement.fr", "service-public.fr" and "data.gouv.fr" open in a new tab (
taget="_blank").They should bear titles like : "legifrance.gouv.fr - ouvre une nouvelle fenêtre"
This is not the case on our app and on the Footer component documentation
Should the Footer component be modified or should it be added by another script ?
The text was updated successfully, but these errors were encountered: