use explicit type for mock body #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenpunt
changed the title
|
This breaks the build, please fix. |
to correctly handle the serialized JSON
|
I think my changes are not the actual issue here. The problem is that Faraday handles the JSON serialization, and Webmock removed support for hashes as response in a minor version update. But I have a solution, I have replaced all webmock stubbing with faraday stubbing (see last commit). |
|
I like it, merging. Thank you. |
dblock
added a commit
that referenced
this pull request
Nov 30, 2014
use explicit type for mock body
|
You're welcome, I'll look into updating the features as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a hash is ambiguous, and triggers an error since webmock v1.20.2
see bblimke/webmock#427 for more information