Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using truthy check instead of count($data) at Model::doProtectFields() #1485

Closed

Conversation

samsonasik
Copy link
Member

For performance improvement.

Checklist:

  • Securely signed commits

@lonnieezell
Copy link
Member

While the truthy check might be marginally faster, the difference is negligible and I feel that, in this case, count() is clearer. Passing on this one, but thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants