Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manual define "system/" directory prefix at ComposerScripts #1551

Conversation

samsonasik
Copy link
Member

So in case the "system" directory is renamed, the composer update will install to new renamed directory/ThirdParty directory.

Checklist:

  • Securely signed commits

Copy link
Contributor

@jim-parry jim-parry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? Won't composer put stuff in a vendor folder, unless explicitly configured to use system/ThirdParty?

@samsonasik
Copy link
Member Author

For example, I do fresh install, and rename system directory. In next month, I do composer update, and in that time, there is update for thirdparty part, eg: Zend\Escaper, so, without this, the updated dependency will not go to the new renamed system directory.

@samsonasik
Copy link
Member Author

this should be steps to reproduce:

  • rename system directory
  • update autoload "system" in composer.json
  • remove {new system directory}/Thirdparty/*
  • composer update

@samsonasik
Copy link
Member Author

without this change, we will get the following error when system directory renamed and do composer update:

screen shot 2018-11-29 at 8 56 17 pm

@lonnieezell
Copy link
Member

I have no issues with this. Looks like needed for those using composer who don't like our naming system :)

@jim-parry jim-parry added this to the 4.0.0 milestone Nov 29, 2018
@jim-parry jim-parry merged commit 8714368 into codeigniter4:develop Dec 6, 2018
@samsonasik samsonasik deleted the composer-script-reduce-manual-define-system-dir branch December 6, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants