Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache robustness #4697

Merged
merged 1 commit into from
May 19, 2021
Merged

Cache robustness #4697

merged 1 commit into from
May 19, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented May 17, 2021

Description
Cache's FileHandler still chokes in some circumstances when files are unreadable or non-existent. This PR routes all file access through getItem() and adds some extra robustness to make sure Cache won't take down the whole app when it has problems.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • n/a Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner merged commit eb243d3 into codeigniter4:develop May 19, 2021
@MGatner MGatner deleted the filehandler-crash branch May 19, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @paulbalandan