-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add RELEASE.md #687
docs: add RELEASE.md #687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, however I'm not sure I'm the person who should approved, maybe MGatner or lonnieezell would be better to see here. I have not experienced this.
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
Added notes to items that require administrator privileges. |
* Title: "Prep for 1.x.x release" | ||
* Description: "Updates version references for `1.x.x`." (plus checklist) | ||
* Let all tests run, then review and merge the PR | ||
* Create a new PR from `develop` to `master`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't normally go through all this trouble for a package. Not opposed, but it makes the release harder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that not creating a PR but just run git merge
?
When releasing a package, I normally just tag in a version branch like 1.x
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for pulling this together.
No description provided.