Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add RELEASE.md #687

Merged
merged 5 commits into from
Apr 7, 2023
Merged

docs: add RELEASE.md #687

merged 5 commits into from
Apr 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 22, 2023

No description provided.

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, however I'm not sure I'm the person who should approved, maybe MGatner or lonnieezell would be better to see here. I have not experienced this.

admin/RELEASE.md Show resolved Hide resolved
admin/RELEASE.md Outdated Show resolved Hide resolved
admin/RELEASE.md Outdated Show resolved Hide resolved
admin/RELEASE.md Show resolved Hide resolved
@kenjis
Copy link
Member Author

kenjis commented Mar 23, 2023

Added notes to items that require administrator privileges.

* Title: "Prep for 1.x.x release"
* Description: "Updates version references for `1.x.x`." (plus checklist)
* Let all tests run, then review and merge the PR
* Create a new PR from `develop` to `master`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't normally go through all this trouble for a package. Not opposed, but it makes the release harder.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that not creating a PR but just run git merge?

When releasing a package, I normally just tag in a version branch like 1.x.

@datamweb datamweb added the documentation Improvements or additions to documentation label Apr 5, 2023
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for pulling this together.

@kenjis kenjis merged commit a5096be into codeigniter4:develop Apr 7, 2023
@kenjis kenjis deleted the docs-RELEASE.md branch April 7, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants