Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reuse github workflows #128

Merged
merged 3 commits into from
Sep 10, 2023
Merged

chore: reuse github workflows #128

merged 3 commits into from
Sep 10, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 7, 2023

No description provided.

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Sep 7, 2023
@kenjis kenjis mentioned this pull request Sep 7, 2023
Closed
9 tasks
@MGatner
Copy link
Member

MGatner commented Sep 9, 2023 •
edited
Loading

Sorry, same. Looks good after rebase. Also consider DevKit Rector requirement.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6133096289

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.673%
Totals Coverage Status
Change from base Build 6130396413: 0.0%
Covered Lines: 332
Relevant Lines: 422
💛 - Coveralls

@MGatner
Copy link
Member

MGatner commented Sep 10, 2023

Any idea what happened to the Rector workflows?

@kenjis
Copy link
Member Author

kenjis commented Sep 10, 2023

I have no idea.
It seems the jobs was just cancelled, but by what?

I reran, and passed.

@kenjis kenjis merged commit ced5f45 into codeigniter4:develop Sep 10, 2023
32 of 33 checks passed
@kenjis kenjis deleted the reuse-ga-workflows branch September 10, 2023 21:02
This was referenced Sep 11, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @coveralls