Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation on closed file #128

Open
stardust85 opened this issue Feb 18, 2016 · 2 comments
Open

Operation on closed file #128

stardust85 opened this issue Feb 18, 2016 · 2 comments

Comments

@stardust85
Copy link
Contributor

We see intermittent test https://travis-ci.org/codeinn/vcs/jobs/110129783#L350, probably caused by race condition in subprocessio library. This library is used only in one place (GitRepository in git backend).

I propose to change subprocessio.py to standard pypi module 'subprocess32'. It's python 2.4+ backport of subprocess standard module from python 3.

Makes sense?

@stardust85
Copy link
Contributor Author

I also use subprocess in perforce backend, so switch to subprocess32 will be super-easy there, it's backwards compatible

@marcinkuzminski
Copy link
Member

Subprocessio is a very special module a non-blocking Subprocess lib that uses threads to read in/out. It cannot be replaced by subprocess32 unfortunetly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants