Fix FS Events forwarding to xhyve VM #150
Conversation
Just noticed that today and I tracked down the root cause to a blanky
`SSHKeyPath` on the VM's state that results in wrong arguments being
passed on to `fsevents_to_vm`:
```
$ docker-machine create remove --driver xhyve
....
Docker is up and running!
To see how to connect your Docker Client to the Docker Engine running on
this virtual machine, run: docker-machine env remove
$ docker-machine inspect remove | grep -i sshkey
"SSHKeyPath": "",
```
This might be something to be fixed on the driver's side but I guess it
does the trick for now.
|
Oh good catch thanks. Have you filed an issue with the xhyve driver? It does seem like something they should fix. |
Not yet, I haven't had a chance to dig into it as I was unable to build it locally neither I know how exactly drivers should behave in regard to that. But I'll try to look into it tomorrow. Either way, unless we want to implement custom logic based on the driver version, I guess we might want to keep this little hack around while the behavior gets dealt with upstream and a new release is out 😅 WDYT? |
|
Yeah for sure, I just want to make sure they're aware of it |
|
Doh, I just released dinghy 4.3.0 and forgot to merge this first 😵 Merging and releasing 4.3.1. Thanks again! |
Fix FS Events forwarding to xhyve VM
Just noticed that today and I tracked down the root cause to a blanky
SSHKeyPathon the VM's state that results in wrong arguments being passed on tofsevents_to_vm:This might be something to be fixed on the driver's side but I guess it does the trick for now.