This repository has been archived by the owner on May 9, 2020. It is now read-only.

Fix eslint #126

Merged

codemanki merged 2 commits into codemanki:master from unknown repository

Mar 9, 2019

ghost commented Mar 9, 2019 •

edited by ghost

Loading

Apparently eslint wasn't enforcing the SemiStandard coding style because I hadn't configured it properly.

Added eslint-plugin-json to lint package.json for errors
Replaced new Buffer calls with Buffer.from, it is deprecated in nodejs v6+
Added a rule to allow the imports to be aligned i.e. var pkg = require('...')
Added the necessary mocha environment flag to test files
Fixed all coding style issues

pro-src added 2 commits

March 9, 2019 00:32


          Only call errback with the error argument

853486f


          Properly configure eslint and fix coding style issues

ccc8966

codemanki merged commit 77d5673 into codemanki:master

ghost deleted the eslint branch

March 9, 2019 12:41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet