Add type declarations for simple-mode #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are based on the type definitions in wrote for codemirror5 in DefinitelyTyped, omitting the
mode
property of the rule that does not exist anymore, and changingmeta
tolanguageData
.The weird generic on
simpleMode<K extends string>()
is because typescript does not allow defining a different type forlanguageData
when usingP in string
instead of a generic (that will be inferred as the the union of state names instead of the fullstring
type)