Increase delay for input refocus after backspace on Android #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Marijn!
Following up on my bug report on some backspacing issues on Android here, these two commits seem to have helped:
however, when I was testing this locally on my Google Pixel running Android 10, the timeout for refocusing after backspace input wasn't quite long enough which led to the virtual keyboarding not reopening when it should have. I suspect for older, less powerful devices, the virtual keyboard takes longer to close which leads to the heuristic in the set timeout flaking.
Using the following minimal repro:
and linking a local version of
@codemirror/view
viayarn link
, I was able to work around the issue by increasing the timeout from 50 to 100ms.Additionally, I noticed that we can forego the blur/set timeout logic for the enter key which we're also processing in the
beforeinput
handler.Think this should help address the above issue, although ideally we triage the root cause that causes the virtual keyboard to close in the first place.