Improve drawSelection to take into account textIndent

[lishid]

FIX: Properly draw selections when text-indent is used for soft wrapping.

[marijnh]

Since text-indent will only affect the first line of an element, won't this go wrong when the line is actually wrapped, allowing the continued lines to stick out of the drawn selection block?

[lishid]

Yes, but I think it looks more correct when the selection block aligns with the left side where the first line starts:

Before patch:

After patch:

[lishid]

Ah I see what you mean - if the editor is using positive text indent (just for that line), it will screw up the drawn selection for the rest of the document.

EDIT: In my case, I was using positive padding and negative text-indent to achieve soft wrapping.

[lishid]

Ok, how about this? This would always draw the selection pieces to include the left-most part of either the first line or the subsequent lines. I think that's likely the behavior that's the most desired in either situation.

[marijnh]

I assume you meant Math.min(0, , ...)? As it is, the Math.min call won't have an effect.

[lishid]

My bad! That's exactly what I meant.

[marijnh]

Thanks, merged (minus the semicolon) as 97119e3