Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare font attributes early #33

Closed
wants to merge 2 commits into from
Closed

declare font attributes early #33

wants to merge 2 commits into from

Conversation

thomas992
Copy link

@thomas992 thomas992 commented Mar 18, 2022

codemirror/dev#775
declare font style normal, font monospace and font width on cm-editor. Fixes print style and removes font style inheritance from parent

@thomas992
Copy link
Author

maybe remove font monospace from cm-scroller?

@thomas992 thomas992 changed the title Do not inherit font attributes from parent declare font attributes earlier Mar 18, 2022
@thomas992 thomas992 changed the title declare font attributes earlier declare font attributes early Mar 18, 2022
@marijnh
Copy link
Member

marijnh commented Mar 19, 2022

This is not the solution to that issue, which is about the editor not measuring its layout, and can only be incidentally solved in this way when the gutters don't declare any font size or type that differs from the lines and no lines are wrapped.. I'll take a look at the issue next week.

@marijnh marijnh closed this Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants