Add aria label to editor view for accessibility purposes

[sfc-gh-klin]

This is the second of two PRs I have opened for accessibility (the first was here).

I'm interested in adding an aria-label field for the editor textbox to meet the guidelines of this accessibility check.

I went with the value "editor" to try to stay succinct and convey that the textbox is for the code editor that the user interacts with on their screen. What do you think?

[marijnh]

I think "editor" conveys zero additional information, since the screen reader will already announce it as an editable input, and only clutters up the reading. People are encouraged to add a meaningful label via contentAttributes, but this doesn't seem helpful. Was it inspired by actual feedback from a screen reader user, or are you just trying to hush an automatic checker?

[sfc-gh-klin]

The latter--an automatic checker. What do you suggest for the aria-label field?

[marijnh]

Same as with other input fields—something that tells the user what it is they are editing. But that is context-dependent, and thus not something that should be baked into the library itself.