Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other components that extend the editor's DOM have a
destroy
method that allows them to clean up any resources they created (e.g.PluginValue
,Panel
). I've been missing such a method for theTooltipView
as well. Although I found a workaround by usingMutationObserver
like soI think it would be nice to have such a method for simplicity and consistency.
Note: I extended one of the hover tests but I wasn't able to actually run web tests via
npm run test
. I got an error that the@codemirror/view
dependency doesn't exist (which makes sense) but I don't know what the necessary steps are to get the tests running.