Click within a non-zero-length multi-selection to remove #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently if you have multiple selections in an editor,
Cmd
+Clicking
a 0-length selection will remove it, butCmd
+Clicking
a >0-length selection will not:Screen.Recording.2023-03-27.at.5.43.50.PM.mov
This is because the
.eq
method compares bothhead
andanchor
. When you have a non-zero-length selection those values will not be the same, but the click range will be the same, so.eq
will never returntrue
.Instead, we should check if the click range is anywhere within a selection range when deciding it remove it.
Test Plan
Now, both 0-length and >0-length selections can be added and removed:
Screen.Recording.2023-03-27.at.5.42.44.PM.mov