Fix potential divison by zero when calculating heightMetrics #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: Fixes an issue where the Gutter Element breaks due to a divsion by zero (codemirror/dev#1132)
this.height
seems to always have the same value asthis.height
whenever a line does not wrap. This prevents the division by zero by setting the value ofperChar
to0
, which is always the value whenever the line does not wrap.