Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of EditorConfig.parent #6

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Change type of EditorConfig.parent #6

merged 1 commit into from
Apr 19, 2021

Conversation

bramkragten
Copy link
Contributor

Allows setting DocumentFragment (ShadowRoot) as a parent.

@bramkragten
Change type of EditorConfig.parent
71eb8e4 
Allows setting `DocumentFragment` (`ShadowRoot`) as a parent.
@marijnh
Copy link
Member

marijnh commented Apr 19, 2021

Maybe we should just use Node? That's where TypeScript puts appendChild, which is the only method that's used on parent.

@bramkragten
Copy link
Contributor Author

I considered it, but document is also Node and that can't be used 🤷‍♂️

@marijnh
Copy link
Member

marijnh commented Apr 19, 2021

Neither can TextNode or Attr, I guess. Yeah, the union type is more helpful for people to figure out what is expected here. Merging as-is.

@marijnh marijnh merged commit 566cbab into codemirror:main Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bramkragten @marijnh