Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1430 Avoid exceptions when running in the headless browser mode #68

Closed
wants to merge 2 commits into from

Conversation

ievgennaida
Copy link

@ievgennaida ievgennaida commented Aug 26, 2024

Hi @marijnh,

I've added some checks for undefined values to prevent exceptions occuring when partial browser functionality used during headless Edge runs.

These checks don't change any of the existing logic. My test running smoothly with these fixes.
I would greatly appreciate it if these changes could be released asap.

Thank you!

codemirror/dev#1430

Ensure that code editor is not failing on calling depreacted methods.
Avoid exception that measure is called when this.observer is not initialized (Headless browser mode)
@marijnh
Copy link
Member

marijnh commented Aug 26, 2024

Sorry, no. I'm willing to add workaround for popular browsers, but not for obscure test runners.

@marijnh marijnh closed this Aug 26, 2024
@ievgennaida
Copy link
Author

Sorry, no. I'm willing to add workaround for popular browsers, but not for obscure test runners.

Sorry to hear.
I would like to try to insist to check this again while this is not obscure browsers and this direct usecase when people are performing testing in the ci/cd pipelines.

The function that is fixed used for the printing without any check is deprecated , and this is really obscure.

Please make a great tool usable.

@marijnh
Copy link
Member

marijnh commented Aug 26, 2024

The function that is fixed used for the printing without any check is deprecated , and this is really obscure.

It's only used when the platform doesn't support MediaQueryList.removeEventListener, which is standard and supported on all browsers that have MediaQueryList.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants