Adding error inspection of resource fetched by schema.php #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,6 +115,11 @@ protected function fetchResource($name, $refresh = false) | |||
| return false; | |||
| } | |||
|
|
|||
| // detect http errors in resource fetch call | |||
| if(is_array($config) && array_key_exists('type', $config) && $config['type'] === 'CHttpException') { | |||
There was a problem hiding this comment.
we won't expose the exception type in future, or we cannot guarantee it will always be a CHttpException, let's just assume that if there's an error and if the response is an array, we should throw a CHttpException locally.
There was a problem hiding this comment.
And to repeat myself: The exception we throw here, is not the same that we received from the API. We have a 502 in that case (bad gateway or uplink connection.).
There was a problem hiding this comment.
@phpnode , Good point - however I'm not sure what the possible ['type']s would be. There could be - should we check if it contains the string "Exception" and then throw the 502?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up my previous PR #36 . In some cases the
$configvariable will hold a HTTP exception, and we need to catch this so as to enable more meaningful errors to be returned.The patch will give me e.g.
Error fetching 'productVariant'. CHttpException: Unable to resolve the request "productVariant/options".Instead of
`exception 'CException' with message 'Property "Restyii\Client\Schema\Resource.code" is not defined.``