Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename configuration options #14

Closed
mikehaertl opened this issue Apr 23, 2015 · 2 comments
Closed

Rename configuration options #14

mikehaertl opened this issue Apr 23, 2015 · 2 comments
Labels
enhancement
Milestone
1.1.0

Comments

@mikehaertl
Copy link
Collaborator

With #13 all configuration options will be part of the urlManager component. We therefore should rename some of them so that it's clear that they are related to language options.

Suggested changes:

  • enableDefaultSuffix -> useSuffixForDefaultLanguage
  • enablePersistence -> enableLanguagePersistence
@mikehaertl mikehaertl added this to the 1.1.0 milestone Apr 23, 2015
@ghost
Copy link

ghost commented Apr 24, 2015

For me the new names are OK

mikehaertl added a commit that referenced this issue Apr 24, 2015
@mikehaertl
Fix issue #14: Rename configuration options
970622b
@mikehaertl
Copy link
Collaborator Author

Changed my mind on the first option. It's now called enableDefaultLanguageUrlCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@mikehaertl