Case sensitivity

[kavolorn]

Hi there,

Could you please write why you've decided to lowercase language codes? Is not it more consistent to keep ISO 639-1 codes where last part is in uppercase? Is it possible to make an option which will behave as it was before?

I've just noticed many broken links after update (because some parts of code cannot follow redirects).

Appreciate your work!

[mikehaertl]

Hmm, I think this was mainly my personal preference for all lowercase URLs. But I guess you have a valid point here. Can you check if my commit above helps you? It adds an option keepUpperCaseLanguageCode.

[kavolorn]

Thanks! This commit is working for me though consistency is not perfect yet :)

I have prepared table which explains how I see it.

	Case sensitivity enabled		Case sensitivity disabled
Config language	URL language		URL language
	en-GB	en-gb	en-GB	en-gb
en-GB	VALID	now VALID should 404 or 302 en-GB	302 en-gb	VALID
en-gb	now VALID should 404 or 302 en-gb	VALID	now VALID should 302 en-gb	VALID

Not sure how hard it is to implement such states (because of additional language detection and maybe other things).

Does it make sence?

[mikehaertl]

Config language should never use a lowercase country code, so your line with en-gb is not valid IMO. It must always be en-GB.

I'm also not sure, if we really should be so strict and issue 404 or 302 in the cases you've shown. Notice that you can also use wildcard patterns like en-*. The basic idea was, to make the extension case insensitive with URLs, so that both en-GB and en-gb work - but the former is redirected by default to make URLs unambiguous.

[kavolorn]

Ah, now I understand. I thought that you want to have lowercase codes in configuration also. It is fine how it works now. Thanks for new option!

[mikehaertl]

@kavolorn Ok, thanks. I'll create a 1.4.0 release (new feature). Please note that I will rename keepUpperCaseLanguageCode to keepUppercaseLanguageCode (notice the lowercase c). This is more correct as "uppercase" is a single word in english.

[kavolorn]

Alright! Thanks :)

[kavolorn]

Just noticed that default / url redirects only to lowercase version even keepUppercaseLanguageCode is turned on. Is it a big thing to redirect to uppercase version by default (if option specified)? Thx

[mikehaertl]

Confirmed and (hopefully) fixed in brandnew release 1.4.2 ;)