Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry: TS Codemod - Remove Public Modifier #6

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 31, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds a TS Codemod - Remove Public Modifier

@ghost
Copy link

ghost commented Jan 31, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@hbjORbj hbjORbj changed the title Draft: Registry: TS Codemod - Remove Public Modifier Registry: TS Codemod - Remove Public Modifier Jan 31, 2024
member.type === 'ClassMethod' ||
member.type === 'ClassProperty'
) {
// @ts-expect-error "Property 'accessibility' does not exist on type 'ClassProperty'." is wrong
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that is odd, you can mitigate that with:

if ('accessibility' in member) { ... }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@hbjORbj hbjORbj merged commit 5ef410d into main Feb 1, 2024
6 checks passed
@hbjORbj hbjORbj deleted the ts/codemod-2 branch February 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants