-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmitryburlak #84
Merged
Merged
Dmitryburlak #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Написал тесты для реализации т.з 1.1) При выстреле пуля должна пролетать сквозь кусты
…координате в момент отработки tick()
…tyTest все стырые тесты выкидывали NPE
…м видно кусты и больше никакого движения
…Present = 4, какойто из танков стреляет)
… Scores. Теперь они в GameRunner
Сделал так что 4 тика он выглядит как обычный АИтанк, а на 5 тике меняется
…будет танк с призами
…а отображаются кусты 2) Два танка не могут пройти через друг друга под кустами
update from origin repo
# Conflicts: # CodingDojo/games/battlecity/src/main/java/com/codenjoy/dojo/battlecity/services/GameRunner.java
# Conflicts: # CodingDojo/games/battlecity/src/main/java/com/codenjoy/dojo/battlecity/model/Battlecity.java # CodingDojo/games/battlecity/src/test/java/com/codenjoy/dojo/battlecity/model/BattlecityTest.java
-если только заезжаем - то сразу же начинается занос, то есть запоминается команда которойзаезжали на лед. -eсли съезжаем на землю, то любой занос прекращается тут же.
codenjoyme
reviewed
Sep 26, 2020
@@ -1,7 +1,6 @@ | |||
set ROOT=%CD% | |||
|
|||
set GAMES_TO_RUN=bomberman | |||
rem set GAMES_TO_RUN=tetris,snake,bomberman | |||
set GAMES_TO_RUN=tetris,snake,bomberman,sample,snakebattle,sokoban,spacerace,startandjump,sudoku,rubicscube,a2048,battlecity,chess,collapse,expansion,fifteen,football,hex,icancode,kata,lemonade,loderunner,lunolet,minesweeper,moebius,pong,puzzlebox,quadro,quake2d,reversi,excitebike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не стоило коммитить
codenjoyme
reviewed
Sep 26, 2020
public class AITankPrize extends AITank { | ||
|
||
public static final int CHANGE_AFTER_TICKS = 4; | ||
private List<Bullet> hitsTarget; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
решить с помощью int hitsCount
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.