Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(embedded/store): lock-free WaitForTx and WaitForIndexingUpto implementation #1916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arturmelanchyk
Copy link
Contributor

Using atomic is lock-free and in this specific case roughly ~50% faster than using mutex

@arturmelanchyk
Copy link
Contributor Author

Hi @tomekkolo @SimoneLazzaris
could you guys please take a look into this?

@SimoneLazzaris
Copy link
Collaborator

Looks good to me

@arturmelanchyk
Copy link
Contributor Author

Hi @SimoneLazzaris
I have updated the code to be able to compile with golang 1.17, workflow now should be able to run

@arturmelanchyk
Copy link
Contributor Author

Hi guys,
unfortunately build fails to some coveralls error, not related to the code

bad response status from coveralls: 422
{"message":"Couldn't find a repository matching this job.","error":true}

@tomekkolo @SimoneLazzaris

@tomekkolo
Copy link
Contributor

@arturmelanchyk , please sign commits with GPG

…plementation

Signed-off-by: Artur Melanchyk <artur.melanchyk@gmail.com>
@arturmelanchyk
Copy link
Contributor Author

Ok, reabased onto latest master and signed commits with GPG. However, coveralls step still fails 🤔

@arturmelanchyk
Copy link
Contributor Author

Just a kind reminder @tomekkolo @SimoneLazzaris , branch has been rebased onto latest master and all commits signed with GPG

@tomekkolo
Copy link
Contributor

looked once more, can you provide a benchmark showing the improvement and also using 64 bit is not needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants