IDEX-3576: Add git remote and branch to projects attributes #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok |
| @@ -22,11 +22,17 @@ | |||
| public class GitProjectType extends TransientMixin { | |||
|
|
|||
| public static final String VCS_PROVIDER_NAME = "vcs.provider.name"; | |||
| public static final String CURRENT_BRANCH_NAME = "current.branch.name"; | |||
| public static final String REPOSITORY_REMOTES = "repository.remotes"; | |||
There was a problem hiding this comment.
Actually this variant is also possible, but agree alligment is preferable.
|
ok |
|
|
||
| @Inject | ||
| public GitProjectType(GitValueProviderFactory gitRepositoryValueProviderFactory) { | ||
| super("git", "git"); | ||
| addVariableDefinition(VCS_PROVIDER_NAME, "Is this git repo or not?", false, | ||
| gitRepositoryValueProviderFactory); | ||
| addVariableDefinition(CURRENT_BRANCH_NAME, "Name of current brunch", false, |
|
other OK |
vinokurig
pushed a commit
that referenced
this pull request
Jan 12, 2016
IDEX-3576: Add git remote and branch to projects attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vparfonov @skabashnyuk @sleshchenko please review