add sidebar/nav and routes Co-authored-by: Amr Ahmed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
AlexRS90
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Hello @codepantherr
###What an amazing job, it's working as expected, the styling is like in the design provided and also you created functional components for other features in the project, good one!!
There is nothing else to say other than... is time to merge!!! 🎸 🕺 🎸 🕺
AlexRS90
approved these changes
Mar 29, 2022
src/components/sidebar/Sidebar.jsx
Outdated
Comment on lines
26
to
37
| <nav> | ||
| <ul> | ||
| <li className="nav-item"> | ||
| <NavLink to="/" className="nav-link"> | ||
| Doctors | ||
| </NavLink> | ||
| </li> | ||
| <li className="nav-item"> | ||
| <NavLink to="/book-appointment" className="nav-link"> | ||
| Reserve | ||
| </NavLink> | ||
| </li> |
There was a problem hiding this comment.
- This is an optional Change:
Everything is working as expected but I believe is a good idea to improve de UX to close the menu after the user selects an option.
There was a problem hiding this comment.
You're right, I will work on that now 🤩
AlexRS90
approved these changes
Mar 30, 2022
Comment on lines
+6
to
+12
| useEffect(() => { | ||
| setTheme(localStorage.getItem('theme')); | ||
| const localTheme = theme; | ||
| if (localTheme === 'dark') { | ||
| document.getElementById('theme-toggler').checked = true; | ||
| } | ||
| }, [theme]); |
There was a problem hiding this comment.
This is a great feature, congratulations!!
keep rocking!! 🎸 🕺
|
@AlexRS90 Thank you for the review ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced via this PR: 👇