-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.12.1: undefined method html_options for SimpleNavigation::ItemAdapter #154
Comments
can you post your navigation.rb config file? Thanks. On Thu, Feb 27, 2014 at 8:26 PM, André Veríssimo
|
Can I rund that application (BGFit) myself, ie. can I reproduce the issue On Thu, Feb 27, 2014 at 11:03 PM, André Veríssimo
|
Yes, but the gem dependencies needs octave-ruby package and there are configuration files needed:
Just tried it out and the problem is specific to v3.12.1 |
so 3.12.0 works fine? On Thu, Feb 27, 2014 at 11:45 PM, André Veríssimo
|
Yes 3.12.0 works fine, my bad on reporting on that version! But I can confirm on a clean install of this application (bgfit) that v3.12.1 does not work (when alternating between v3.12.0 or v3.11.0 works fine). I'll try testing on a clean rails app. By the way, you can simply remove the octave-ruby from the Gemfile and avoid having to install additional libraries.. it is not essential Oh and thanks!! Before posting my last reply I checked out the app and tested running it from scratch.. result: found some remnants of some migrations that were raising problems :) |
Ok, thanks, I'll try to debug this over the weekend... On Fri, Feb 28, 2014 at 12:00 AM, André Veríssimo
|
Ok, I think I detected the exact problem: dynamic menus Created a new Rails app and a blank controller
Add the following code to the layout
repo below -- access only via git.. no http viewer :): |
I found the cause of the issue, I'm really sorry, I'll make a PR to fix this. |
I cannot reproduce the problem anymore with master branch. With my BGFit application and test blog. Problem seems solved :) Thank you! p.s. No need to be sorry, thank you for this great gem and fantastic feedback on this issue! :) |
Fix deployed in 3.12.2 On Fri, Feb 28, 2014 at 7:17 PM, André Veríssimo
|
I have the same issue version 4.0.3 It's rises with default example: primary.item :key_2, 'name', '' do |sub_nav|
# Add an item to the sub navigation (same params again)
sub_nav.item :key_2_1, 'name', ''
end UPD: forget, this is because of simple-navigation-bootstrap renderer |
When upgrading my rails 3.2.13 to v3.12.1 the error below shows in every page that renders menus
I had to revert to v.3.11.0
The text was updated successfully, but these errors were encountered: