Adapt to changed mongoose behaviour #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (Fixes #71)
Explanation
Somewhere along the versions 5.9 to 5.10 several changes where introduced:
So I changed the nModified check to include the new upserted property and am calling next() to return.
Additional
In #72 I tested my fix on different mongoose versions and it passed on both. I also tested with more versions on my machine.
However this tests are not included into CI. I'm not sure if running 30 different version combinations is a good way to go.
I would propose to include Node v14 in the test, but only run with the newest mongoose versions. Your opinion @codepunkt?