Remove compareVersions call, simplify version checking

Author: John McCambridge

packages/server/src/cli.ts

@@ -8,7 +8,7 @@ import * as os from "os";
 import * as path from "path";
 import * as WebSocket from "ws";
 import { buildDir, cacheHome, dataHome, isCli, serveStatic } from "./constants";
-import { getRecentRelease, compareVersions } from "./updater";
+import { getRecentRelease } from "./updater";
 import { createApp } from "./server";
 import { forkModule, requireModule } from "./vscode/bootstrapFork";
 import { SharedProcess, SharedProcessState } from "./vscode/sharedProcess";
@@ -166,50 +166,16 @@ const bold = (text: string | number): string | number => {
 		}
 	}
 
-	let newestVersion = "";
-	if (process.env.VERSION) {
+	if (isCli) {
 		let currentVersion = process.env.VERSION;
 		const recentRelease = await getRecentRelease();
 
-		if (compareVersions(currentVersion, recentRelease)! <= 1) {
-			newestVersion = recentRelease;
-		} else {
-			newestVersion = currentVersion;
+		if (recentRelease !== currentVersion) {
+			logger.warn(`New version (\u001B[1m${recentRelease}\u001B[0m) available https://github.com/codercom/code-server/releases/latest`);
 		}
 	}
-	const isDev = process.env.NODE_ENV !== "production";
-	if (newestVersion === process.env.VERSION || isDev) {
-		logger.info("You are using the latest version");
-	} else {
-		logger.warn(`New version (\u001B[1m${newestVersion}) available https://github.com/codercom/code-server/releases`);
-	}
-	logger.info(`\u001B[1mcode-server ${process.env.VERSION ? `v${process.env.VERSION}` : "development"}`);
-
-	if (options.dataDir) {
-		logger.warn('"--data-dir" is deprecated. Use "--user-data-dir" instead.');
-	}
-
-	if (options.installExtension) {
-		const fork = forkModule("vs/code/node/cli", [
-			"--user-data-dir", dataDir,
-			"--builtin-extensions-dir", builtInExtensionsDir,
-			"--extensions-dir", extensionsDir,
-			"--install-extension", options.installExtension,
-		], {
-			env: {
-				VSCODE_ALLOW_IO: "true",
-				VSCODE_LOGS: process.env.VSCODE_LOGS,
-			},
-		}, dataDir);
-
-		fork.stdout.on("data", (d: Buffer) => d.toString().split("\n").forEach((l) => logger.info(l)));
-		fork.stderr.on("data", (d: Buffer) => d.toString().split("\n").forEach((l) => logger.error(l)));
-		fork.on("exit", () => process.exit());
-
-		return;
-	}
-
 	// TODO: fill in appropriate doc url
+	logger.info(`\u001B[1mcode-server ${process.env.VERSION ? `v${process.env.VERSION}` : "development"}`);
 	logger.info("Additional documentation: http://github.com/codercom/code-server");
 	logger.info("Initializing", field("data-dir", dataDir), field("extensions-dir", extensionsDir), field("working-dir", workingDir), field("log-dir", logDir));
 	const sharedProcess = new SharedProcess(dataDir, extensionsDir, builtInExtensionsDir);