Make custom unique job ID for Travis

$TRAVIS_JOB_NUMBER is unreliable, as it outputs the currently running
job number ($TRAVIS_BUILD_NUMBER.XX) which seems to be the job that
was started last.

Author: Forest Hoffman

.travis.yml

@@ -3,13 +3,14 @@ node_js:
 - 10.15.1
 env:
   matrix:
-  - VSCODE_VERSION="1.33.1" MAJOR_VERSION="1" VERSION="$MAJOR_VERSION.$TRAVIS_BUILD_NUMBER-vsc$VSCODE_VERSION"
+  - VSCODE_VERSION="1.33.1" MAJOR_VERSION="1" VERSION="$MAJOR_VERSION.$TRAVIS_BUILD_NUMBER-vsc$VSCODE_VERSION" CI_JOB_ID="$TRAVIS_BUILD_NUMBER.$TRAVIS_OS_NAME.$RANDOM"
 matrix:
   include:
   - os: linux
     dist: trusty
   - os: osx
 before_install:
+- echo $CI_JOB_ID
 - openssl aes-256-cbc -K $encrypted_31e0a178b4fd_key -iv $encrypted_31e0a178b4fd_iv
   -in test/.coder-gcp-credentials.json.enc -out test/.coder-gcp-credentials.json -d
 - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then

test/src/index.ts

@@ -155,11 +155,10 @@ export class TestPage {
 		const img = await this.rootPage.screenshot(options);
 		++this.screenshotCount;
 
-		// If this is a Travis CI build, store the screenshots
-		// for later.
-		if (process.env.TRAVIS_OS_NAME && process.env.TRAVIS_JOB_NUMBER) {
+		// If this is a Travis CI build, store the screenshots.
+		if (process.env.CI_JOB_ID) {
 			const makePublic = true;
-			const bucketPath = `Travis-${process.env.TRAVIS_JOB_NUMBER}/${fileName}`;
+			const bucketPath = `Travis-${process.env.CI_JOB_ID}/${fileName}`;
 			let buf: Buffer = typeof img === "string" ? Buffer.from(img as string) : img;
 			try {
 				const url = await bucket.write(bucketPath, buf, makePublic);