Skip to content

Commit e19ce0f

Browse files
author
Forest Hoffman
committed
Wait for editor instead of tab when opening file
1 parent db2298e commit e19ce0f

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

test/src/chrome.test.ts

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,7 @@ describe("chrome e2e", () => {
7474
.then(server.loadPage.bind(server));
7575

7676
// Editor should be visible.
77-
const editor = await server.querySelector(page, "div.part.editor");
78-
expect(editor).toBeTruthy();
79-
expect(editor.tag).toEqual("div");
80-
expect(editor.properties).toBeDefined();
81-
expect(editor.properties!["id"]).toBe("workbench.parts.editor");
82-
expect(editor.children.length).toBeGreaterThan(0);
77+
await page.waitFor("div.part.editor", { visible: true });
8378
});
8479

8580
it("should create file via command palette", async () => {
@@ -134,16 +129,9 @@ describe("chrome e2e", () => {
134129
await workbenchQuickOpen(page);
135130
await page.keyboard.type(testFileName, { delay: 100 });
136131
await page.keyboard.press("Enter");
137-
const tabSelector = `div.tab div.monaco-icon-label.${testFileName.replace(".", "\\.")}-name-file-icon`;
138-
await page.waitFor(tabSelector);
139-
140-
// Check that the file is in an editor tab.
141-
const tab = await server.querySelector(page, tabSelector);
142-
expect(tab).toBeTruthy();
143-
expect(tab.tag).toEqual("div");
144-
expect(tab.properties).not.toBeUndefined();
145-
expect(tab.properties!["title"]).toContain(testFileName);
146-
expect(tab.children.length).toBeGreaterThan(0);
132+
133+
// File should be open in editor view.
134+
await page.waitFor(editorSelector, { visible: true });
147135
});
148136

149137
it("should install extension", async () => {

0 commit comments

Comments
 (0)